Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 compatibility #164

Merged
merged 9 commits into from
Feb 11, 2024
Merged

Python 3.12 compatibility #164

merged 9 commits into from
Feb 11, 2024

Conversation

howroyd
Copy link
Contributor

@howroyd howroyd commented Jan 29, 2024

Removed dependency on imp which is depreciated and removed in Python 3.12. Replaced with importlib as suggested in the issue below (https://docs.python.org/3.12/whatsnew/3.12.html#imp).

Install tested OK on 3.12 and 3.11.

Closes #163

@howroyd howroyd force-pushed the py3v12-compatability branch 3 times, most recently from dd75506 to 4724c93 Compare January 29, 2024 15:48
@howroyd howroyd marked this pull request as ready for review January 29, 2024 16:05
@howroyd
Copy link
Contributor Author

howroyd commented Jan 29, 2024

Github actions all passed on my fork for Python 3.8-3.12 on linux, mac and win.

I am not able to test lower versions as your action is not setup to do that and I didn't want to add it. A bit of effort would be needed as there is not a default container provided by Github with the older versions in it.

@coveralls
Copy link

Coverage Status

coverage: 97.892%. remained the same
when pulling 481e53d on howroyd:py3v12-compatability
into f88b6cb on Knio:master.

@Knio Knio merged commit 802bfb6 into Knio:master Feb 11, 2024
16 checks passed
@howroyd howroyd deleted the py3v12-compatability branch February 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs porting to Python 3.12
3 participants