Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs porting to Python 3.12 #163

Closed
stefanor opened this issue Jan 22, 2024 · 1 comment · Fixed by #164
Closed

Needs porting to Python 3.12 #163

stefanor opened this issue Jan 22, 2024 · 1 comment · Fixed by #164

Comments

@stefanor
Copy link

Python 3.12 dropped the imp module.

https://docs.python.org/3.12/whatsnew/3.12.html#imp

The code using imp should be ported to importlib
howroyd added a commit to howroyd/pynmea2 that referenced this issue Jan 29, 2024
@howroyd
Remove dependency on imp removed in 3.12
b67ae2d 
https://docs.python.org/3.12/whatsnew/3.12.html#imp

Closes Knio#163
@howroyd howroyd mentioned this issue Jan 29, 2024
Merged
@Knio Knio closed this as completed in #164 Feb 11, 2024
@OnurKader OnurKader mentioned this issue May 6, 2024
Closed
@dreirund
Copy link

dreirund commented May 17, 2024 •
edited
Loading

@Knio closed this as completed in #164 on Feb 11

Can you make a new release, including the fix, so that distributions that use releases and not latest git state can pick up easily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python 3.12 compatibility howroyd/pynmea2
2 participants
@stefanor @dreirund