Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit breaker action configuration changes. #69

Merged
merged 3 commits into from Dec 19, 2019
Merged

Circuit breaker action configuration changes. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d4786e
Exchange fallback transition with _fallback.
tomaszmichalak Dec 19, 2019
8210691
Remove the 'fallbackOnFailure' option as it is forced by the circuit …
tomaszmichalak Dec 19, 2019
77bbb15
Changelog update
tomaszmichalak Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ All notable changes to `knotx-stack` will be documented in this file.

## Unreleased
List of changes that are finished but not yet released in any final version.
- [PR-69](https://github.com/Knotx/knotx-stack/pull/69) - Circuit breaker: `_fallback` transition && fallback on failure strategy

## 2.1.0
- [PR-68](https://github.com/Knotx/knotx-stack/pull/68) - Fix unit tests with custom wiremock instance.
Expand Down
5 changes: 2 additions & 3 deletions ...ctionalTest/resources/scenarios/long-running-http-service-with-circuit-breaker/tasks.conf
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ global.handler.fragmentsHandler.config {
tasks {
books-listing {
action = book-with-circuit-breaker
onTransitions.fallback {
onTransitions._fallback {
action = book-inline-body-fallback
}
}
Expand All @@ -18,7 +18,7 @@ global.handler.fragmentsHandler.config {
actions = [
{
action = book-with-circuit-breaker
onTransitions.fallback {
onTransitions._fallback {
action = book-inline-payload-fallback
}
},
Expand All @@ -43,7 +43,6 @@ global.handler.fragmentsHandler.config {
timeout = 1000
maxFailures = 1
resetTimeout = 10000
fallbackOnFailure = true
}
}
doAction = book
Expand Down