Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp YAML manifest so we can access history, and also put this in tar file along with nodes/edges files #268

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

justaddcoffee
Copy link
Collaborator

Put date/timestamp in filename of YAML manifest, and tar it up with nodes and edges files in tar file

Note that I'm not including this with the RDF/ntriples file, since this isn't an archive

@justaddcoffee justaddcoffee marked this pull request as draft July 6, 2020 18:48
@justaddcoffee justaddcoffee requested a review from kltm July 6, 2020 18:52
@kltm
Copy link
Contributor

kltm commented Jul 6, 2020

Towards the top of your pipeline, you have:

                            sh 'echo $START_DAY > dow.txt'

Once upon a time, you probably generated that variable at the beginning of the run; now it just remains as reminder of the original codebase.
I would note that you call date twice. While low probability now, in future cutting and pasting, or if you are unlucky, you can get different results. I would maybe suggest re-introducing the env variables like DATE to the start of the run, as you used to have above--it might make it a little easier as you slowly move towards versioning.

@justaddcoffee
Copy link
Collaborator Author

@kltm better?

@kltm
Copy link
Contributor

kltm commented Jul 6, 2020

@justaddcoffee Assuming that works, that's probably a safer way of doing things. At least in my mind.

@justaddcoffee justaddcoffee marked this pull request as ready for review July 10, 2020 20:42
@justaddcoffee justaddcoffee merged commit ce87a74 into master Jul 10, 2020
@justaddcoffee justaddcoffee deleted the include_yaml_manifest_in_tar branch July 10, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants