Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type edges as associations #307

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Conversation

deepakunni3
Copy link
Member

This PR,

  • types edges as biolink:Association. This is now required by KGX to reify an edge when exporting as RDF
  • also specifies the type for certain properties. This ensure that the value of these properties are treated properly when exporting RDF

@deepakunni3
Copy link
Member Author

@justaddcoffee After we merge this PR we should be ready to run the pipeline.

This PR would also get rid of the bug where interaction scores from STRING was being treated as string. Now it would be treated as xsd:float. Also, this is configurable as seen in merge_kg.py

@justaddcoffee
Copy link
Collaborator

Looks good

@deepakunni3 deepakunni3 merged commit c5d3c53 into master Aug 7, 2020
@justaddcoffee justaddcoffee deleted the type-edges-as-associations branch August 7, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants