Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to install with phpstan-extensions installer #709

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Allow to install with phpstan-extensions installer #709

merged 2 commits into from
Aug 6, 2022

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 6, 2022

Hi @TomasVotruba, according to https://github.com/phpstan/extension-installer#instructions-for-extension-developers
this would allow to use phpstan/extension-installer to automatically install this extension.

@VincentLanglet
Copy link
Contributor Author

The rector build seems unrelated ; dunno if I should fix it

@TomasVotruba
Copy link
Contributor

Hi, you can apply Rector by running it:

vendor/bin/rector process

I'll review changes after the CI passed 👍

@VincentLanglet
Copy link
Contributor Author

Hi, you can apply Rector by running it:

vendor/bin/rector process

I'll review changes after the CI passed 👍

Done

@TomasVotruba
Copy link
Contributor

Awesome, thank you 👍

@TomasVotruba TomasVotruba merged commit aa7c160 into KnpLabs:master Aug 6, 2022
@VincentLanglet
Copy link
Contributor Author

Awesome, thank you 👍

You're welcome. If you have time for a release it would be great.

@VincentLanglet VincentLanglet deleted the patch-1 branch August 6, 2022 11:04
@TomasVotruba
Copy link
Contributor

@VincentLanglet
Copy link
Contributor Author

Thanks a lot. Just tried and it works perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants