Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom module names #87

Merged
merged 6 commits into from
Jul 6, 2018
Merged

feat: Custom module names #87

merged 6 commits into from
Jul 6, 2018

Conversation

Kocal
Copy link
Owner

@Kocal Kocal commented Jul 1, 2018

When using this on BetterCounter.vue:

/**
 * @module better-components/BetterCounter
 * ...
 */

capture d ecran de 2018-07-03 21-43-55

Other components without manually defined module name are not altered with this feature.

It close #83

@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files           4        4           
  Lines          31       31           
  Branches        7        7           
=======================================
  Hits           26       26           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4552002...138746d. Read the comment docs.

@Kocal Kocal changed the title WIP: feat: Custom Module Names feat: Custom Module Names Jul 3, 2018
@Kocal Kocal changed the title feat: Custom Module Names feat: Custom module names Jul 3, 2018
@Kocal
Copy link
Owner Author

Kocal commented Jul 3, 2018

@sbowler @linkdd let me know if this feature match your usage case 👍

@Kocal
Copy link
Owner Author

Kocal commented Jul 4, 2018

(Waiting for @sbowler before merging)

@Kocal Kocal merged commit f2e673a into master Jul 6, 2018
@Kocal Kocal deleted the feat/83 branch July 6, 2018 04:37
@Kocal
Copy link
Owner Author

Kocal commented Jul 6, 2018

Released in v2.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Custom Module Names
2 participants