Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device information to MQTT message payload #374

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

stas-demydiuk
Copy link
Contributor

Add basic device information to each MQTT message to make it possible to somehow recognize devices (type, manufactor, model, etc.) for 3rd party plugins

@stas-demydiuk
Copy link
Contributor Author

@Koenkk Any chances to have this merged? These changes are required to make working my integration with Domoticz (https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin)

@Koenkk
Copy link
Owner

Koenkk commented Sep 19, 2018

Thanks for the pr!

As this functionality is not always needed and because it adds a lot of stuff to the payloads, could you make this a setting in configuration.yaml? For homeassistant we have homeassistant: true, I propose to make something similar for domoticz (domoticz: true)

@stas-demydiuk
Copy link
Contributor Author

stas-demydiuk commented Sep 19, 2018

@Koenkk what do you think about more generic option in configuration.yml file, smth like

mqtt > send_device_information: true|false

as this option might be useful for some other integrations as well not especially for Domoticz?

@Koenkk
Copy link
Owner

Koenkk commented Sep 19, 2018

I'm fine with that, what do you think of include_device_information?

@stas-demydiuk
Copy link
Contributor Author

stas-demydiuk commented Sep 19, 2018

@Koenkk Sounds good, updated the PR

@Koenkk
Copy link
Owner

Koenkk commented Sep 20, 2018

Great, thanks!

@Koenkk Koenkk merged commit a448ed3 into Koenkk:dev Sep 20, 2018
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants