Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button RESPAWN doesn't work with alive #1553

Closed
commy2 opened this issue Nov 17, 2014 · 11 comments
Closed

Button RESPAWN doesn't work with alive #1553

commy2 opened this issue Nov 17, 2014 · 11 comments
Assignees
Labels
Milestone

Comments

@commy2
Copy link
Collaborator

commy2 commented Nov 17, 2014

From alive:

class RscDisplayMPInterrupt: RscStandardDisplay {
    class controls {
        delete ButtonAbort;
    };
};

They delete our RESPAWN-button...

Requesting label: 3rd Party Mod's fault.

@commy2 commy2 added the bug label Nov 17, 2014
@commy2 commy2 self-assigned this Nov 17, 2014
@commy2 commy2 added this to the Version 0.95 milestone Nov 17, 2014
commy2 pushed a commit that referenced this issue Nov 17, 2014
@commy2
Copy link
Collaborator Author

commy2 commented Nov 17, 2014

Can someone confirm this fix? Not gonna install alive for that. Can only be tested in multiplayer while unconscious.

@lubomirblazekcz
Copy link
Contributor

not fixed, when you hit respawn you will also hit alive abort mission..
Question, why there are the Abort and Respawn buttons in AGM anyway? For respawn module?

@nicolasbadano
Copy link
Collaborator

Question, why there are the Abort and Respawn buttons in AGM anyway?

Short answer, it's really needed for very important reasons.

Long answer, with some simplifications: when unconscious we need to open a fake invisible dialog to block mouse movements moving the player; so Esc closes the dialog instead of opening the menu. To allow the players to abort, respawn, etc we open the menu through a script command, but it doesn't work the same way as when it's opened through the real Esc key. So we reimplement what happens when you press the abort and respawn buttons. Alive messes with that menu too, changing the names/adding custom code to the existing buttons instead of adding new ones, so both things clash.

We may change the way we block mouse inputs in the future, hopefully removing this problem. Until then, we may not be able to completely solve this, IDK.

@lubomirblazekcz
Copy link
Contributor

What about moving the respawn button directly below abort? That is not possilble?

@commy2 commy2 reopened this Dec 18, 2014
@commy2
Copy link
Collaborator Author

commy2 commented Dec 18, 2014

Can anyone make a screenshot and explain what button I can actually use? I'm not gonna install alive with all those .dlls on my machine.

@lubomirblazekcz
Copy link
Contributor

which dlls do you mean?

Some screenshots below:
alive menu only
alive-menu

unconscious in 0.94.1
094

unconscious in 0.95
095

@lubomirblazekcz
Copy link
Contributor

now when I think about it.. what about move abort back down instead of respawn? When alive is used you can still abort, when not you can abort too.

@jonpas
Copy link
Contributor

jonpas commented Dec 19, 2014

which dlls do you mean?

I believe he means DLLs that come with ALiVE.

Why are they messing with those buttons in the first place...

@lubomirblazekcz
Copy link
Contributor

I believe he means DLLs that come with ALiVE.

Well I have alive and I don't have any dlls with it

commy2 pushed a commit that referenced this issue Dec 20, 2014
@commy2
Copy link
Collaborator Author

commy2 commented Dec 20, 2014

Thanks, the pictures helped.
I moved the RESPAWN button to the actual RESPAWN button in MP.
I hope alive doesn't change that one too.

@lubomirblazekcz
Copy link
Contributor

Tested and it works without any problems now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants