codeintel2: Python: Fixes relative imports #14
Conversation
Relative improts where always based on the main buffer's path. Instead, use current relative path (if there is one) for relative imports. Fixes the case where a module `module.first` imports `module.first.some` by using relative import `import .some` and the current buffer's path is not in `module/first`.
|
@Kronuz, any chance you could elaborate on this PR? |
It is not true. «from ...xxx import yyy» syntax works for Python 2 and Python 3, and even supported by pylint checker. |
|
I never said |
|
Yes, «import .whatever» is invalid, but I was asked to comment «in Python it is illegal to use a relative import to refer to modules located in a different directory on the filesystem» |
|
Yes, that's fair. When taken out of this PR's context, the sentence you quoted can be false under most interpretations. |
|
Closing this, as we cannot commit it without a proper test case, and there has been no response for over a year and a half. |
Relative improts where always based on the main buffer's path.
Instead, use current relative path (if there is one) for relative
imports.
Fixes the case where a module
module.firstimportsmodule.first.someby using relative import
import .someand the current buffer's pathis not in
module/first.