Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request balance and utxos for both P2KH and P2PKH script hashes from Electrum. #720

Closed
artemii235 opened this issue Sep 18, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request Good test task

Comments

@artemii235
Copy link
Member

artemii235 commented Sep 18, 2020

As of now MM2 uses only P2PKH script hash so it might get incorrect balance and utxos from Electrum if the address has P2PK utxos.

https://discordapp.com/channels/412898016371015680/449950331577565194/756147006237573150

kyuupichan/electrumx#818 (comment)

@artemii235
Copy link
Member Author

We should also consider implementing the same for Native mode.

@artemii235 artemii235 added the enhancement New feature or request label Jan 13, 2021
@michelvankessel
Copy link

I can confirm this happens with Coinstakes too. (Blackcoin, PoSv3)

@cipig
Copy link
Member

cipig commented Jun 15, 2022

would solving this issue also make it possible to see and spend the timelocked transactions from TKL?
the vout of such a tx in question looks like this

    {
      "value": 62854.37046316,
      "valueSat": 6285437046316,
      "n": 1,
      "scriptPubKey": {
        "asm": "1655251200 OP_NOP2 OP_DROP OP_DUP OP_HASH160 4d2a1a4748205d088a382f2023cad8ea6403f6cc OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "040021a962b17576a9144d2a1a4748205d088a382f2023cad8ea6403f6cc88ac",
        "type": "pubkeyhash"
      }
    }

if so, then it would be nice if he could prioritize this, some TKL rewards were unlocked today and can not be seen or spent on ADEX Desktop with electrums

@smk762
Copy link

smk762 commented Apr 28, 2023

@shamardy @ozkanonur can we please implement this?
I just encountered the same discrepancy between explorer balance and API balance related to this.

@shamardy
Copy link
Collaborator

@shamardy @ozkanonur can we please implement this?

Sure, I can take a look at it next week.

@shamardy
Copy link
Collaborator

Fixed here #2053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Good test task
Projects
None yet
Development

No branches or pull requests

5 participants