Python: byte buffers + exception pass through #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farizrahman4u
commented
Feb 2, 2020
•
farizrahman4u
commented
- No copy support for byte buffers
- Python exceptions thrown by user's code is now surfaced as Java exception
- cleanups
Closed
AlexDBlack
added a commit
that referenced
this pull request
Feb 4, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
quickwritereader
pushed a commit
that referenced
this pull request
Feb 7, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
sshepel
pushed a commit
that referenced
this pull request
Feb 12, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
sshepel
pushed a commit
that referenced
this pull request
Feb 12, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
sshepel
pushed a commit
that referenced
this pull request
Feb 12, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
sshepel
pushed a commit
that referenced
this pull request
Feb 12, 2020
* wrapper * builtins * context mgr * direct place * ret all var * call fix * fix ndarray serde * jobs * try-with gil management * cleanup * exec tests passing * list tests * transforms test passing * all pass * headers * dict fixes+test * python path * bool isinstance * job tests * nits * transform fix+test * transform tests * leak fixes * more mem leak fixes * more fixes * nits for adam * PythonJob lombok builder * checked exceptions * more nits * small leak fix * more nits * pythonexceptions * fix jvm crash when bad python code * Exception->PythonException * Add support for boolean types in arrow records and ability to cast from float, double to int for TypeConversion (#178) * nits for alex * update tests * fix test * all pass * refacc * rem old code * dtypes * bytes working+exception pass through+cleanup (#209) * more bytes tests * header * rem dummy test * rem bad import * alex nits + refacc * Small error fixes (wrong type in msg) + minor formatting Signed-off-by: AlexDBlack <blacka101@gmail.com> * use actual python type names (dictionary->dict, boolean->bool) Co-authored-by: Shams Ul Azeem <shamsazeem20@gmail.com> Co-authored-by: Alex Black <blacka101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.