-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD breaks install #33
Comments
I got the same issue and posted in here : Kong/kong#5520 |
Can you try the following?
We have to keep compatibility with Helm v2 and hence the above flag is necessary if you CRDs already exist in the cluster. |
It works now, thank you so much. |
This problem is actually worse. |
@hbagdi hmm. that is unfortunate. I wonder how other projects handle this. I can do some research. In the meantime, do we want to update the docs to make it clear for helm 3, you must set that value to |
We should. PR welcome! |
will do! So I believe the reason this is not an issue in other projects is that they use the |
@hbagdi PR opened. |
Just to clarify for anyone passing by: That's not a valid |
It seems to me that the issue is that the template file should not try to install the crd's when using Helm 3, since Helm 3 will do that already. |
I've asked in the I think that all of this stems from having a |
Docs are missing for installation for Helm3. #34 As much as I wish to drop support for Helm 2, I don't think it is reasonable at this point given that Helm 3 came out relatively recently and most users are still on Helm 2. |
I guess you mean Helm 2
Helm 3 have done a fairly good job of making it backwards compatible. A valid Helm 2 chart (i.e. with |
I correct my comment about. Sorry for the typo.
Probably not. That's the only change we introduced to work towards Helm 3 compatibility. The more I think about it, the more I feel that we should revert the @rainest Thoughts? |
that would be really unfortunate. It would certainly break our workflow and require two separate stages for helm install. As I mentioned above - I believe the other projects provide helm 3 support without breaking helm 2 by using a Barring that, do you believe docs for helm 3 (in my PR) would be insufficient for providing support for helm 3 for those that want it? |
One strategy that would for sure work is to have one file in But that leads to repeated code, which is pretty unfavorable. |
Alright, I believed that we had a reason for not using the It is worth a try to solve this problem by introducing the Can someone in this thread open a quick PR to add those hook annotation to the chart? |
I hope to be able to get to it in the next few days... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The text was updated successfully, but these errors were encountered: