Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] EDN Formatting, Optional commas highlighted as errors #1451

Closed
kernelp4nic opened this issue Apr 23, 2019 · 3 comments
Closed

[Bug] EDN Formatting, Optional commas highlighted as errors #1451

kernelp4nic opened this issue Apr 23, 2019 · 3 comments
Labels
stale Bot: Stale Issue

Comments

@kernelp4nic
Copy link

  • Insomnia Version: Version 6.4.0 (6.4.0.2712)
  • Operating System: macOS Mojave 10.14.4

Details

Commas in EDN are highlighted as errors in the latest release:

image

Commas are optional in EDN notation, from docs:

Elements are generally separated by whitespace. Whitespace, other than within strings, is not otherwise significant, nor need redundant whitespace be preserved during transmissions. Commas , are also considered whitespace, other than within strings.

This wasn't happening on previous releases.

@welcome
Copy link

welcome bot commented Apr 23, 2019

👋 Thanks for opening your first issue! If you're reporting a 🐞 bug, please make sure
you include steps to reproduce it. If you're requesting a feature 🎁, please provide real
use cases that would benefit. 👪

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Contributor

gschier commented Apr 23, 2019

It looks like this happened when upgrading Codemirror.

I can reproduce this on the official Codemirror Clojure mode demo. It seems like this may be the patch that introduced it if you'd like to leave a comment there.

@gschier gschier changed the title EDN Formatting, Optional commas highlighted as errors [Bug] EDN Formatting, Optional commas highlighted as errors Apr 23, 2019
@stale
Copy link

stale bot commented Jun 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Bot: Stale Issue label Jun 22, 2019
@stale stale bot closed this as completed Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Bot: Stale Issue
Projects
None yet
Development

No branches or pull requests

2 participants