Skip to content
This repository has been archived by the owner on Mar 27, 2020. It is now read-only.

Delete obsolete charts directory #42

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Conversation

stackedsax
Copy link
Contributor

@shashiranjan84 Isn't this directory rendered obsolete from the work you did to put cassandra and postgres into the requirements.yaml?

Assuming so, so I figured I'd just clean this up a bit. Plus, I just keep getting confused about which template and values file I'm looking at...

@shashiranjan84
Copy link
Contributor

Yes, I am aware of this. I had this problem during packaging and wanted to research about it later

image

Any idea why this failing?

@stackedsax
Copy link
Contributor Author

I am in the exact same hell. I have zero idea why this is happening.

It is interesting, though, that if you unpack those tgz's into charts, everything is fine.

@stackedsax
Copy link
Contributor Author

Figured it out! It's an errant *.tgz in the .helmignore file. Removing it makes things workout just fine.

@stackedsax
Copy link
Contributor Author

stackedsax commented Dec 11, 2017

Ok, good to go now.

I guess ignoring *.tgz doesn't prevent the downloading of other packages, but it does prevent the building of our new package with those *.tgz's.

@shashiranjan84
Copy link
Contributor

I figured out too while working on official chart for Kubeapps hub https://github.com/shashiranjan84/charts/commits/master.

Thanks for PR.

@stackedsax
Copy link
Contributor Author

@shashiranjan84 Good to know!

A couple q's:

  • Do you still want to merge any of these PR's?
  • Should we move to doing development in that official repo from now on?
  • Should we take this chart down and put a README directing people to where the chart will actually live?
  • And do you want to put your work in incubator/ rather than stable/ over there? I feel like that's where this wip work should go until it's a bit more baked.

@shashiranjan84
Copy link
Contributor

Do you still want to merge any of these PR's?

Yes, we will maintain this repo and add Kong-EE options

Should we move to doing development in that official repo from now on?
Should we take this chart down and put a README directing people to where the chart will actually live?

For now both will be maintained

And do you want to put your work in incubator/ rather than stable/ over there? I feel like that's where this wip work should go until it's a bit more baked.

No, will make sure we meet stable criteria before sending PR

@shashiranjan84 shashiranjan84 merged commit 413df58 into Kong:master Dec 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants