This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(*) create baggage items in child spans #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
would it be possible to add a test to prevent regressions? |
kikito
approved these changes
Feb 10, 2021
|
While it would be nice to have tests for this, the baggage tags have no tests (being a leftover from previous versions). I am merging this change without tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the
new_childspan methods we added an additional argument by mistake -sample_ratiofor the span initializer, which overrides the baggage argument. this fix suppose to pass the correct argument to this method