Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) bump or compat vers #3070

Merged
merged 2 commits into from
Dec 2, 2017
Merged

chore(*) bump or compat vers #3070

merged 2 commits into from
Dec 2, 2017

Conversation

p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented Dec 2, 2017

No description provided.

The CLI `quit` command would even on a forceful exit still
print a 'graceful shutdown' message.

From #3061
@p0pr0ck5
Copy link
Contributor Author

p0pr0ck5 commented Dec 2, 2017

@thibaultcha are we missing anything here in a version bump?

@thibaultcha
Copy link
Member

thibaultcha commented Dec 2, 2017

@p0pr0ck5 I don't think so, except purging the Travis cache if not done already, and maybe a somewhat clearer commit message for archeology purposes (say, containing "OpenResty" for the pickaxe tool).

@thibaultcha
Copy link
Member

thibaultcha commented Dec 2, 2017

I think a good reference is to look at previous commit and following the same message structure: 9ac6be5

@p0pr0ck5
Copy link
Contributor Author

p0pr0ck5 commented Dec 2, 2017

Nice, thanks for the refs! Travis is indeed "purged" (e.g., not available via cache) because of the vers. difference. We can see this empirically via Travis logs.

I've adjust the commit msg as per the referenced commit above. Thanks!

@thibaultcha
Copy link
Member

Oops, my bad - I think an OpenResty bump should go into next only!

@thibaultcha
Copy link
Member

If we change the base branch to next, then the approval stands! :)

@p0pr0ck5 p0pr0ck5 changed the base branch from master to next December 2, 2017 03:17
@p0pr0ck5
Copy link
Contributor Author

p0pr0ck5 commented Dec 2, 2017

Dang it! And I thought I got this right the first time ;) Okay, merging into next as intended (ignoring human error, whops!).

@p0pr0ck5 p0pr0ck5 merged commit b207c65 into next Dec 2, 2017
@p0pr0ck5 p0pr0ck5 deleted the chore/or-version branch December 2, 2017 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants