feat(tcp-log) TLS handshake support for TCP logs #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0pr0ck5
force-pushed
the
feat/tcp-log-tls
branch
from
0306a57
to
a0ce08d
Compare
thibaultcha
approved these changes
Dec 14, 2017
kong/plugins/tcp-log/handler.lua
Outdated
| ok, err = sock:sslhandshake(true, conf.tls_sni, false) | ||
| if not ok then | ||
| ngx.log(ngx.ERR, "[tcp-log] failed to perform TLS handshake to ", | ||
| host, ":", port, ": ", err) |
There was a problem hiding this comment.
style: we typically apply an exception to ngx.log and align subsequent arguments with the 2nd one ("...) 😅
| @@ -0,0 +1,21 @@ | |||
| local plugin_config_iterator = require("kong.dao.migrations.helpers").plugin_config_iterator | |||
|
|
|||
| return { | |||
There was a problem hiding this comment.
style: new file, could we respect the 2 lines jump rule? Thanks!
thibaultcha
added
pr/changes requested
p0pr0ck5
force-pushed
the
feat/tcp-log-tls
branch
from
a0ce08d
to
f1b1512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support TLS connections for remote TCP servers in the
tcp-logplugin.Full changelog
tcp-log:tls, a boolean indicating whether to perform a TLS handshake against the remote server, andtls_sni, and optional string defining the SNI hostname to send in the handshake.tlsis true.tcp_serverhelpers construct.