TCP Log plugin add datatypes, missing TLS params #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlblessing
added
blocked:kong
ghost
reviewed
Feb 24, 2021
There was a problem hiding this comment.
description for tls and tls_sni can be found here: Kong/kong#3091
tls, a boolean indicating whether to perform a TLS handshake against the remote server
tls_sni, and optional string defining the SNI hostname to send in the handshake.
Thank you @murillopaula! Wow, that change was made in 2017--4 years ago. |
tlblessing
changed the title
ghost
approved these changes
Feb 24, 2021
lena-larionova
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://konghq.atlassian.net/browse/DOCS-1396 epic to add datatypes to plugins beyond the few template-autogenerated parameters. I'm not logging Jira subtickets because it's a lot of overhead.
Schema links:
https://github.com/Kong/kong-ee/blame/master/kong/plugins/tcp-log/schema.lua
https://github.com/Kong/kong/blob/master/kong/db/schema/typedefs.lua
Direct review link:
https://deploy-preview-2624--kongdocs.netlify.app/hub/kong-inc/tcp-log/
REVIEWERS: I noticed some fields in the schema that aren't present in the docs. There isn't a readme to go by that I can find either. Can you please assist? Update: Murillo to the rescue.