fix(dao) select NULL fields as nil from the proxy #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal changes to add a { nulls = true } options argument to the new
DAO, so that by default it returns Lua `nil` on null values, but can
also return explicit `ngx.null` upon request. Adjusts the Admin API
endpoint generator to pass this option, and also the router (so that
code changes to the router at this point are minimal).
Fix #3609
Fix #3617
When reading from the proxy, we do not wish to retrieve unset columns as `ngx.null` for backwards-compatibility reasons. That is now the default for all plugins since 735314c (parent commit), for plugins, and it is now for the runloop as well. Context: retrieving unset columns as `nil` instead of `ngx.null` allows for backwards-compatibility with existing plugins. An example of this is authentication plugins retrieving the authenticated Consumer, and injecting its fields as headers into the upstream request (e.g. `X-Consumer-Username`). When such fields are unset, the following headers were sent upstream: `X-Consumer-Username: userdata: NULL` instead of no header at all (or worse, producing HTTP 500 errors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading from the proxy, we do not wish to retrieve unset columns as
ngx.nullfor backwards-compatibility reasons. That is now the defaultfor all plugins since 735314c (parent commit), for plugins, and it is
now for the runloop as well.
Context: retrieving unset columns as
nilinstead ofngx.nullallowsfor backwards-compatibility with existing plugins. An example of this is
authentication plugins retrieving the authenticated Consumer, and
injecting its fields as headers into the upstream request (e.g.
X-Consumer-Username). When such fields are unset, the followingheaders were sent upstream:
X-Consumer-Username: userdata: NULLinstead of no header at all (or worse, producing HTTP 500 errors).
This replaces parts of (but not all) #3710.