perf(router) if header matching is not used, don't read headers #9327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
perf/router-header-matching
branch
3 times, most recently
from
6b27621
to
e7ed0eb
Compare
bungle
changed the title
bungle
added
pr/wip
chronolaw
approved these changes
Aug 27, 2022
bungle
force-pushed
the
perf/router-header-matching
branch
from
e7ed0eb
to
c50220b
Compare
chronolaw
reviewed
Aug 29, 2022
### Summary Optimize `traditional_compatible` and `expressions` router to not read headers in case there are no routes with header matching rules.
bungle
force-pushed
the
perf/router-header-matching
branch
from
c50220b
to
4259777
Compare
bungle
added
pr/ready
bungle
added a commit
that referenced
this pull request
Aug 31, 2022
### Summary Optimize `traditional_compatible` and `expressions` router to not read headers in case there are no routes with header matching rules. # Conflicts: # kong/router/atc_compat.lua
bungle
added a commit
that referenced
this pull request
Aug 31, 2022
### Summary Adds missing tests to perf pr that was recently merged, see: #9327. This tests that `ngx.reg.get_headers` is called only when there are routes with header matching rules.
jschmid1
pushed a commit
that referenced
this pull request
Sep 1, 2022
### Summary Adds missing tests to perf pr that was recently merged, see: #9327. This tests that `ngx.reg.get_headers` is called only when there are routes with header matching rules.
chronolaw
added a commit
that referenced
this pull request
Sep 2, 2022
chronolaw
added a commit
that referenced
this pull request
Sep 8, 2022
chronolaw
added a commit
that referenced
this pull request
Sep 21, 2022
chronolaw
added a commit
that referenced
this pull request
Sep 26, 2022
chronolaw
added a commit
that referenced
this pull request
Oct 6, 2022
chronolaw
added a commit
that referenced
this pull request
Oct 9, 2022
dndx
pushed a commit
that referenced
this pull request
Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant #9327 * transplant #9329 * transplant #9343 * transplant #9346 * transplant #9357 * transplant #9389 * transplant #9394 * transplant #9451 * transplant #9480
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant Kong#9327 * transplant Kong#9329 * transplant Kong#9343 * transplant Kong#9346 * transplant Kong#9357 * transplant Kong#9389 * transplant Kong#9394 * transplant Kong#9451 * transplant Kong#9480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize
traditional_compatibleandexpressionsrouter to not read headers in case there are no routes with header matching rules.