fix(router): check empty route field #9451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dndx
reviewed
Sep 21, 2022
chronolaw
force-pushed
the
fix/router_with_empty_hosts
branch
from
4a1f76a
to
8957fff
Compare
chronolaw
changed the title
|
Hi, please remember to cherry-pick this into |
bungle
reviewed
Sep 22, 2022
bungle
approved these changes
Sep 22, 2022
dndx
reviewed
Sep 23, 2022
dndx
approved these changes
Sep 26, 2022
|
Just a reminder to create a cherry pick PR against |
1 task
dndx
pushed a commit
that referenced
this pull request
Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant #9327 * transplant #9329 * transplant #9343 * transplant #9346 * transplant #9357 * transplant #9389 * transplant #9394 * transplant #9451 * transplant #9480
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant Kong#9327 * transplant Kong#9329 * transplant Kong#9343 * transplant Kong#9346 * transplant Kong#9357 * transplant Kong#9389 * transplant Kong#9394 * transplant Kong#9451 * transplant Kong#9480
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #9450