Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(router) add more test cases for incremental build #9357

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 1, 2022

Summary

Adjust some test cases to fit flavor traditional_compatible and expressions.

Changes:

  • remove unnecessary expression/priority in test
  • due to YIELD_ITERATIONS is 1000 now, change test loop to 2000
  • add more test cases

@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 1, 2022
@chronolaw chronolaw changed the title tests(router)remove unnecessary expression/priority in test tests(router) add more test cases for incremental build Sep 1, 2022
@chronolaw chronolaw marked this pull request as ready for review September 1, 2022 01:20
@chronolaw chronolaw requested a review from a team as a code owner September 1, 2022 01:20
@chronolaw chronolaw added the chore Not part of the core functionality of kong, but still needed label Sep 1, 2022
@chronolaw chronolaw requested a review from dndx September 1, 2022 02:30
@github-actions github-actions bot removed the chore Not part of the core functionality of kong, but still needed label Sep 1, 2022
@bungle bungle merged commit aa7ec86 into master Sep 1, 2022
@bungle bungle deleted the tests/incremental_build_cases branch September 1, 2022 14:13
dndx pushed a commit that referenced this pull request Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua`
* add a new file `expressions.lua`
* move lots of logic into `atc.lua`
* rename `get_atc` to `get_expression`
* rename `route_priority` to `get_priority`
* rename `atc_escape_str `to `escape_str`
* remove function `paths_resort`
* transplant #9327 
* transplant #9329 
* transplant #9343
* transplant #9346
* transplant #9357
* transplant #9389
* transplant #9394
* transplant #9451
* transplant #9480
oowl pushed a commit to oowl/kong that referenced this pull request Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua`
* add a new file `expressions.lua`
* move lots of logic into `atc.lua`
* rename `get_atc` to `get_expression`
* rename `route_priority` to `get_priority`
* rename `atc_escape_str `to `escape_str`
* remove function `paths_resort`
* transplant Kong#9327 
* transplant Kong#9329 
* transplant Kong#9343
* transplant Kong#9346
* transplant Kong#9357
* transplant Kong#9389
* transplant Kong#9394
* transplant Kong#9451
* transplant Kong#9480
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants