Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do not run on CI for non-main branches #4221

Closed
1 task
pmalek opened this issue Jun 26, 2023 · 0 comments · Fixed by #4223
Closed
1 task

Tests do not run on CI for non-main branches #4221

pmalek opened this issue Jun 26, 2023 · 0 comments · Fixed by #4223
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.

Comments

@pmalek
Copy link
Member

pmalek commented Jun 26, 2023 •
edited
Loading

Problem statement

It was discovered that CI doesn't run on PRs targeting branches other than main, e.g. #4216

What we're especially interested in, are the release/v* release branches.

Specifically https://github.com/Kong/kubernetes-ingress-controller/blob/f1b345b33ab7fc8233f6df09242f3d0c273aa0e7/.github/workflows/pr_checks.yaml workflow is not run.

Accepted criteria

  • As a developer, whenever I create a PR I can expect tests to run to validate my changes.
@pmalek pmalek added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jun 26, 2023
@pmalek pmalek mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run PR checks on PRs against all branches Kong/kubernetes-ingress-controller
1 participant
@pmalek