chore: graduate feature gate FillIDs to Beta and set to true by default #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
the
area/maintenance
programmer04
force-pushed
the
fillids
branch
from
c99eafd
to
07bc694
Compare
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6328663139 |
auto-merge was automatically disabled
September 27, 2023 16:25
Pull request was converted to draft
programmer04
force-pushed
the
fillids
branch
from
07bc694
to
9e2846c
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4746 +/- ##
=======================================
- Coverage 67.9% 67.8% -0.1%
=======================================
Files 165 165
Lines 19291 19291
=======================================
- Hits 13102 13087 -15
- Misses 5420 5433 +13
- Partials 769 771 +2
☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
fillids
branch
from
9e2846c
to
f5bcffa
Compare
pmalek
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Graduate feature gate
FillIDsto Beta and set totrueby default. Adjust code, tests (regenerate golden tests tests cases), CI, etc. Mention it inCHANGELOG.MDandFEATURE_GATES.md.Which issue this PR fixes:
Closes #4739
Special notes for your reviewer:
Dereferencing any field in
KongConsumeris risky, because each one is a pointer, thus when an error is returned (it was the case for envtests that don't care about it) panic occurred. UsingFriendlyName(...)is always safePR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR