-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(istio): Update getKialiWorkloadHealth
to adapt to different istio versions
#6183
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9462665513 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6183 +/- ##
======================================
Coverage ? 73.7%
======================================
Files ? 198
Lines ? 19798
Branches ? 0
======================================
Hits ? 14604
Misses ? 4205
Partials ? 989 ☔ View full report in Codecov by Sentry. |
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9463818620 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
What this PR does / why we need it:
Istio 1.22 removed Kiali API
/namespaces/<ns>/health
and uses/namespace/<ns>/workloads/<workload>
instead. While Istio 1.17 does not support the newer API. So the PR uses different APIs for different istio versions.Also, this PR adds istio
1.22.1
into tests.Which issue this PR fixes:
fixes #6039
Special notes for your reviewer:
Istio 1.17 (and 1.18,1.19) are already end of support: https://istio.io/latest/docs/releases/supported-releases/. Should we just remove these versions in our istio tests? The official support of Istio only includes the latest 3 nimor versions.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR