test(istio): Update getKialiWorkloadHealth to adapt to different istio versions
#6183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9462665513 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6183 +/- ##
======================================
Coverage ? 73.7%
======================================
Files ? 198
Lines ? 19798
Branches ? 0
======================================
Hits ? 14604
Misses ? 4205
Partials ? 989 ☔ View full report in Codecov by Sentry. |
programmer04
previously approved these changes
Jun 11, 2024
pmalek
reviewed
Jun 11, 2024
2 tasks
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9463818620 |
pmalek
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Istio 1.22 removed Kiali API
/namespaces/<ns>/healthand uses/namespace/<ns>/workloads/<workload>instead. While Istio 1.17 does not support the newer API. So the PR uses different APIs for different istio versions.Also, this PR adds istio
1.22.1into tests.Which issue this PR fixes:
fixes #6039
Special notes for your reviewer:
Istio 1.17 (and 1.18,1.19) are already end of support: https://istio.io/latest/docs/releases/supported-releases/. Should we just remove these versions in our istio tests? The official support of Istio only includes the latest 3 nimor versions.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR