Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix totalResults handling when Kustvakt returns cache results #219

Open
Akron opened this issue Sep 26, 2024 · 0 comments
Open

Fix totalResults handling when Kustvakt returns cache results #219

Akron opened this issue Sep 26, 2024 · 0 comments
Assignees

Comments

@Akron
Copy link
Member

Akron commented Sep 26, 2024

Kustvakt 0.71.1 introduced a totalResult cache, that rewrites the KoralQuery in the way that is not handled by Kalamar correctly. It introduces a cutoff but returns a totalResult. Currently Kalamar ignores the totalResults for cutoff queries.
It's debatable if Kustvakt should make the cached results indistinguishable from non-cached results and don't change the cutoff.

This shoud probably also be discussed with other client devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants