Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sqlite paper managers #9

Open
j6k4m8 opened this issue Jun 6, 2023 · 4 comments
Open

Support sqlite paper managers #9

j6k4m8 opened this issue Jun 6, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@j6k4m8
Copy link
Member

j6k4m8 commented Jun 6, 2023

This should also optionally track all edits (as diffs) for debugging.
@j6k4m8 j6k4m8 added enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2023
@wrongu
Copy link
Contributor

wrongu commented Jun 7, 2023

Is this not already available as git history?

@wrongu wrongu mentioned this issue Jun 7, 2023
Open
@j6k4m8
Copy link
Member Author

j6k4m8 commented Jun 7, 2023

Sure, but poorly-defined to get out tuples of (edit request, before, after) and also requires pulling the full git history into memory which is annoying and slow...

@j6k4m8
Copy link
Member Author

j6k4m8 commented Jun 7, 2023

^

  • also overleaf rewrites its history all the time because it's not actually a git history
  • also also this would handle paper pointer management, not just edit tracking

@wrongu
Copy link
Contributor

wrongu commented Jun 12, 2023

while you're at it, you should turn PaperRemote.dict() into an actual class specification, and generalize the loading in the managers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j6k4m8 @wrongu