-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search for events #237
Comments
This is really a good idea! |
Hello! I would like to try to add this feature if it hasn’t already been started. I have the base functionality working, but I have a couple of questions. Here is what I propose:
|
Hi! Thanks for your proposal! 😄
Sound good to me, maybe the date arguments should be named
This function is not released yet (will be available in Kosmorrolib 1.1, which I'd like to release once Kosmorro 1.0 is released). So, you can start making your development after updating the lib to
The proposed output in your screenshot seems good to me, just remove the seconds and we'll be fine :)
To me, searching for events without providing dates has no real sense, so we can require them.
I think the search mode should be considered as an special execution mode, so everything that is not related (ephemerides, moon phase) should be removed.
Let's give freedom to the user, no maximum range here. There is no real need for that. |
I agree! I think
Yes, this sounds good to me. I am working on implementing this and the other comments above now! |
Currently kosmoro allows you to obtain a list of events from dates. The idea would be to be able to do the opposite, get dates from an event.
I think that it is necessary to define default ranges (we are not going to generate dates ad infinitum) and to be able to specify them. I think we should also indicate if we want future/past/both dates.
The text was updated successfully, but these errors were encountered: