Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug using @file:ImportDataSchema #140

Closed
Jolanrensen opened this issue Aug 5, 2022 · 1 comment · Fixed by #247
Closed

Bug using @file:ImportDataSchema #140

Jolanrensen opened this issue Aug 5, 2022 · 1 comment · Fixed by #247
Assignees
@ermolenkodev
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@Jolanrensen
Copy link
Collaborator

If I generate a DataSchema using @file:ImportDataSchema() and then create a new manual @DataSchema interface which references any generated code, it doesn't generate.
It works well using the gradle dataframes {} notation.
@koperagen
Copy link
Collaborator

Hm, i've got an idea. Probably a generator just ignores manual data schema because it has invalid reference (reference to a class that doesn't yet exist. I think there is a mechanism to defer symbol to the next round of the code generation, so we just need to use it

@Jolanrensen Jolanrensen added the bug Something isn't working label Oct 28, 2022
@Jolanrensen Jolanrensen added this to the 0.10.0 milestone Nov 28, 2022
@ermolenkodev ermolenkodev self-assigned this Jan 27, 2023
ermolenkodev added a commit to ermolenkodev/dataframe that referenced this issue Jan 31, 2023
@ermolenkodev
Enable multi-round DataSchema declaration processing in DataFrameSymb…
3512f1f 
…olProcessor (Kotlin#140)

By enabling multi-round DataSchema declaration processing we add support for generation of DataSchema declaration
references another declaration  generated by @file:ImportDataSchema

Fixes Kotlin#140
ermolenkodev added a commit to ermolenkodev/dataframe that referenced this issue Jan 31, 2023
@ermolenkodev
Enable multi-round DataSchema declaration processing (Kotlin#140)
6db647c 
By enabling multi-round DataSchema declaration processing we add support for generation of DataSchema declaration
references another declaration  generated by @file:ImportDataSchema

Fixes Kotlin#140
@ermolenkodev ermolenkodev mentioned this issue Jan 31, 2023
Merged
ermolenkodev added a commit to ermolenkodev/dataframe that referenced this issue Jan 31, 2023
@ermolenkodev
Enable multi-round DataSchema declaration processing (Kotlin#140)
19fcce6 
By enabling multi-round DataSchema declaration processing we add support for generation of DataSchema declaration
references another declaration  generated by @file:ImportDataSchema

Fixes Kotlin#140
ermolenkodev added a commit that referenced this issue Feb 1, 2023
@ermolenkodev
Merge pull request #247 from ermolenkodev/140
514d3dd 
Enable multi-round DataSchema declaration processing (#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ermolenkodev ermolenkodev

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Enable multi-round DataSchema declaration processing (#140) ermolenkodev/dataframe
3 participants
@koperagen @Jolanrensen @ermolenkodev