Enable multi-round DataSchema declaration processing (#140) #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By enabling multi-round DataSchema declaration processing we add support for generation of DataSchema declaration references another declaration generated by @file:ImportDataSchema Fixes Kotlin#140
koperagen
reviewed
Jan 31, 2023
|
|
||
| fun main() { | ||
| val df: DataFrame<Repos> = DataFrame.readJson("data/jetbrains_repositories.json") as DataFrame<Repos> | ||
| df.repositories[0].print() |
There was a problem hiding this comment.
Just a note: this code is only compiled, not executed
There was a problem hiding this comment.
Yes, I got it. I made it this way to illustrate the idea of why this multi-round generation can be needed)
koperagen
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling multi-round DataSchema declaration processing, we add support for the generation of DataSchema declaration references another declaration generated by @file:ImportDataSchema
Fixes #140