Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about geometry dimension, working space dimesion and local space dimension #9369

Closed
miguelmaso opened this issue Nov 19, 2021 · 4 comments
Closed

Comments

@miguelmaso
Copy link
Contributor

Description
Recently I had some confusions using the geometry dimensions. As an example, some of the geometries define the following dimensions:

Dimension Working space dimension Local space dimension
Line3D2 3 3 1
Triangle3D3 2 3 2
Tetrahedra3D4 3 3 3
Line2D2 2 2 1
Triangle2D3 2 2 2
Quadrilateral2D4 2 2 2

On the one hand side, there are three dimensions defined. From my point of view, there are only two spaces: the local space and the global/working one. What does mean dimension? On the other hand, how is it possible that the Line3D2 has dimension=3 and the triangle3D3 has dimension=2?

@loumalouomega
Copy link
Member

This confuses me as well

@rubenzorrilla
Copy link
Member

I've the feeling that Dimension is legacy and what one should trust is WorkingSpaceDimension and LocalSpaceDimension (what is what we normally do).

@roigcarlo
Copy link
Member

roigcarlo commented Sep 28, 2022

@KratosMultiphysics/technical-committee We are discussing how to make Dimension() consistent. Since this is hardly doable automatically (can't do search and replace), our suggestion is to deprecate Dimension() and use WorkingDimension() or LocalDimension()

The way to go should be:

  • Deprecateor remove Dimension()
  • Manually change calls to Dimension() (should be ~100)
  • Finally delete Dimension()

@rubenzorrilla
Copy link
Member

I think that after #10977 the roadmap is completed 🎉

LEGACY Technical Committee automation moved this from In progress to Done May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants