Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove Dimension #10977

Merged
merged 11 commits into from
Apr 11, 2023
Merged

[Core] Remove Dimension #10977

merged 11 commits into from
Apr 11, 2023

Conversation

rubenzorrilla
Copy link
Member

@rubenzorrilla rubenzorrilla commented Apr 6, 2023

📝 Description
As agreed before, this will finally remove the Dimension method from the geometry classes as well as the GeometryData and GeometryDimension ones.

Related to #10445.

@rubenzorrilla rubenzorrilla self-assigned this Apr 6, 2023
@rubenzorrilla rubenzorrilla added this to To do in LEGACY Technical Committee via automation Apr 6, 2023
@rubenzorrilla rubenzorrilla moved this from To do to Next meeting todo in LEGACY Technical Committee Apr 6, 2023
@rubenzorrilla rubenzorrilla added this to Upcoming in Deprecations Apr 6, 2023
@loumalouomega
Copy link
Member

At last

loumalouomega
loumalouomega previously approved these changes Apr 6, 2023
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it will break something in the CI, anyway, approving

CMakeLists.txt Outdated Show resolved Hide resolved
rubenzorrilla and others added 2 commits April 6, 2023 15:29
Co-authored-by: Vicente Mataix Ferrándiz <vmataix@altair.com>
@matekelemen
Copy link
Contributor

Does this mean I'll be able to see my compiler output again? You're a life saver! <3

@rubenzorrilla rubenzorrilla marked this pull request as ready for review April 7, 2023 19:42
@rubenzorrilla rubenzorrilla requested review from a team as code owners April 7, 2023 19:42
@loumalouomega
Copy link
Member

Yay

@rubenzorrilla rubenzorrilla merged commit 0fb273c into master Apr 11, 2023
@rubenzorrilla rubenzorrilla deleted the all/get-rid-of-Dimension branch April 11, 2023 17:08
LEGACY Technical Committee automation moved this from Next meeting todo to Done Apr 11, 2023
Deprecations automation moved this from Upcoming to Already Done Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Deprecations
  
Already Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants