Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All][KratosCore] Deprecate Dimension() #10445

Merged
merged 1 commit into from
Nov 25, 2022
Merged

[All][KratosCore] Deprecate Dimension() #10445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kratos/geometries/geometry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,6 +1284,7 @@ class Geometry
@see WorkingSpaceDimension()
@see LocalSpaceDimension()
*/
KRATOS_DEPRECATED_MESSAGE("'Dimension' is deprecated. Use either 'WorkingSpaceDimension' or 'LocalSpaceDimension' instead.")
inline SizeType Dimension() const
{
return mpGeometryData->Dimension();
Expand Down Expand Up @@ -2418,7 +2419,7 @@ class Geometry
this->GlobalCoordinates(rResult, IntegrationPointIndex, GetDefaultIntegrationMethod());
}

/**
/**
* @brief This method provides the global coordinates to the corresponding integration point
* @param rResult The global coordinates
* @param IntegrationPointIndex The index of the integration point
Expand Down Expand Up @@ -3829,7 +3830,7 @@ class Geometry
std::stringstream buffer;
buffer << "Geometry # "
<< std::to_string(mId) << ": "
<< Dimension() << " dimensional geometry in "
<< LocalSpaceDimension() << "-dimensional geometry in "
<< WorkingSpaceDimension() << "D space";

return buffer.str();
Expand Down
4 changes: 2 additions & 2 deletions kratos/geometries/geometry_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ class GeometryData
@see WorkingSpaceDimension()
@see LocalSpaceDimension()
*/
KRATOS_DEPRECATED_MESSAGE("'Dimension' is deprecated. Use either 'WorkingSpaceDimension' or 'LocalSpaceDimension' instead.")
SizeType Dimension() const
{
return mpGeometryDimension->Dimension();
Expand Down Expand Up @@ -738,8 +739,7 @@ class GeometryData
/// Print object's data.
virtual void PrintData( std::ostream& rOStream ) const
{
rOStream << " Dimension : " << mpGeometryDimension->Dimension() << std::endl;
rOStream << " working space dimension : " << mpGeometryDimension->WorkingSpaceDimension() << std::endl;
rOStream << " Working space dimension : " << mpGeometryDimension->WorkingSpaceDimension() << std::endl;
rOStream << " Local space dimension : " << mpGeometryDimension->LocalSpaceDimension();
}

Expand Down
2 changes: 1 addition & 1 deletion kratos/geometries/geometry_dimension.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class GeometryDimension
@see WorkingSpaceDimension()
@see LocalSpaceDimension()
*/
KRATOS_DEPRECATED_MESSAGE("'Dimension' is deprecated. Use either 'WorkingSpaceDimension' or 'LocalSpaceDimension' instead.")
inline SizeType Dimension() const
{
return mDimension;
Expand Down Expand Up @@ -165,7 +166,6 @@ class GeometryDimension
/// Print object's data.
virtual void PrintData( std::ostream& rOStream ) const
{
rOStream << " Dimension : " << mDimension << std::endl;
rOStream << " Working space dimension : " << mWorkingSpaceDimension << std::endl;
rOStream << " Local space dimension : " << mLocalSpaceDimension;
}
Expand Down