[GeoMechanicsApplication] Some more cleanup in custom_constitutive
#11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed some commented out code. - Applied the rule of zero to some classes. - Merged some enclosing `if` statements with outer ones. - Avoid implicit narrowing conversions. - When a default constructor can be generated by the compiler use that. - Applied the rule of five to a class. - Put `const` in front of the type name rather than after it. - Replaced several raw `for` loops by calls to `std::copy` and `std::copy_n`. - Some minor layout improvements. - Changed a reference to a reference-to-const. - Uncommented some multi-line comments. - Replaced some old-style inclusion guards by `#pragma once`. - Removed some redundant comments and blank lines. - Don't annotate a member function with both `virtual` and `override`. - Simplified some tests in `if` statements. - Corrected a few spelling mistakes. - Make better use of `KRATOS_ERROR_IF` and `KRATOS_ERROR_IF_NOT`. - Removed some redundant pairs of parentheses. - Avoid hiding member functions that are inherited from a base class (see "C.138: Create an overload set for a derived class and its bases with `using`" from the C++ Core Guidelines). - Replaced some occurrences of `NULL` by `nullptr`.
avdg81
force-pushed
the
geo/code_smells_custom_constitutive
branch
from
bcabda6
to
efbb285
Compare
WPK4FEM
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Fixed several code smells reported by SonarQube in directory
custom_constitutive. Also addressed several problems found by clang-tidy.馃啎 Changelog
ifstatements with outer ones.constin front of the type name rather than after it.forloops by calls tostd::copyandstd::copy_n.#pragma once.virtualandoverride.ifstatements.KRATOS_ERROR_IFandKRATOS_ERROR_IF_NOT.using" from the C++ Core Guidelines).NULLbynullptr.