[Core] make remove installation directories optional #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrubiogonzalez
added
FastPR
jrubiogonzalez
changed the title
roigcarlo
previously approved these changes
Sep 5, 2023
philbucher
requested changes
Sep 5, 2023
philbucher
reviewed
Sep 5, 2023
|
@jrubiogonzalez just out of curiosity:
|
Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
|
We are compiling around 17 applications total between public and private and adding few extra libraries, including mkl. That sums up about 700Mb in win and far more in linux. If we add our environment anti-virus that is quite intrusive (specially in windows) we go in a 0 build (no changes at all) in my workstation from 15s to 5s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
This PR makes removing KratosMultiphysics and libs directory optional. This might be dangerous if some applications get stuck, but on our case as we have plenty of external dll's and several applications this reduces the build time for small changes significantly.