[GeoMechanicsApplication] Addressed several recently introduced code smells #11546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved a variable declaration to inside the `if` statement (to limit the variable's scope as much as possible). - Pass some polymorphic objects by reference to `const`. - Renamed a few function parameters to comply with the Kratos Style Guide. - Improved the code layout. - Don't raise `Exception`, but use a more specific error class. - Only pass a single argument when constructing a `RuntimeError`. - Avoid having an unused loop variable (replaced `i` by `_`). - Use operators `+=` and `-=` when appropriate. - Don't multiply by a hard-coded 1. - Moved reading of GiD output files to its own class and refactored its implementation into smaller and easy to understand methods.
mnabideltares
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Eliminated several recently introduced code smells that have been found by SonarQube.
馃啎 Changelog
ifstatement (to limit the variable's scope as much as possible).const.Exception, but use a more specific error class.RuntimeError.iby_).+=and-=when appropriate.