Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Adding clearing of processes to Clear in AnalysisStage #11547

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This PR makes improvements to the analysis_stage.py file.

Mainly it adds the clearing of processes to the Clear method, where right now only the solver is cleared. This is not only an enhancement, but also it is more consistent with the rest of AnalysisStage, where for example the Check method not only checks the solver, but the processes too.

Additionally, it refactors the Check and Clear methods documentation, adding additonal comments and definitions.

@KratosMultiphysics/altair FYI, we already do this in our custom base analysis class, once this is merged we can remove our local implementation.

🆕 Changelog

@loumalouomega loumalouomega requested a review from a team as a code owner September 8, 2023 13:02
@loumalouomega loumalouomega added this to To do in LEGACY Technical Committee via automation Sep 8, 2023
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@loumalouomega loumalouomega merged commit 4828bf8 into master Sep 8, 2023
11 checks passed
LEGACY Technical Committee automation moved this from To do to Done Sep 8, 2023
@loumalouomega loumalouomega deleted the core/adding-clear-processes-to-nalaysis branch September 8, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants