Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Added a process factory to be used by custom workflows (in C++) #11555

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Sep 12, 2023

馃摑 Description
The factory first needs to be populated with creators for concrete process types that need to be produced. On request, it will produce a smart pointer to a Process instance, thereby supplying a uniform and consistent interface to the processes.

This commit includes the implementation of the factory and a set of unit tests. The actual usage by a custom workflow will be part of another commit.

@avdg81 avdg81 added the GeoMechanics Issues related to the GeoMechanicsApplication label Sep 12, 2023
@avdg81 avdg81 requested a review from WPK4FEM September 12, 2023 19:21
@avdg81 avdg81 self-assigned this Sep 12, 2023
@avdg81 avdg81 requested a review from rfaasse September 12, 2023 19:23
rfaasse
rfaasse previously approved these changes Sep 13, 2023
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean way of implementing the factory (and clear tests)! I have a few minor suggestions/questions, but none of them blocking.

The factory first needs to be populated with creators for concrete
process types that need to be produced. On request, it will produce a
smart pointer to a `Process` instance, thereby supplying a uniform and
consistent interface to the processes.

This commit includes the implementation of the factory and a set of unit
tests. The actual usage by a custom workflow will be part of another
commit.
@avdg81 avdg81 merged commit a4592db into master Sep 13, 2023
11 checks passed
@avdg81 avdg81 deleted the geo/add-process-factory branch September 13, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Create a process factory for custom workflows (in C++)
2 participants