Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Some python binding clean up (I) #11584

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

loumalouomega
Copy link
Member

馃摑 Description

This PR makes changes to two Python interface files, add_amgcl_solver_to_python.cpp and add_bounding_box_to_python.cpp. Here's a summary of the changes:

  1. In add_amgcl_solver_to_python.cpp:

    • Clean up header.
    • Some addiomal clean up and refactor.
  2. In add_bounding_box_to_python.cpp:

    • Clean up header.
    • Some addiomal clean up and refactor.

馃啎 Changelog

@loumalouomega loumalouomega added Cleanup Python FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Sep 21, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner September 21, 2023 11:57
@loumalouomega loumalouomega merged commit 23364c2 into master Sep 21, 2023
11 checks passed
@loumalouomega loumalouomega deleted the core/some-pythpn-clean-up-I branch September 21, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants