Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Extend IntegrationUtilities to Compute Derivatives #11604

Merged
merged 5 commits into from
Sep 26, 2023
Merged

[Core] Extend IntegrationUtilities to Compute Derivatives #11604

merged 5 commits into from
Sep 26, 2023

Conversation

sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented Sep 25, 2023 •
edited

馃摑 Description
This PR extends to have analytical derivative computations for methods IntegrationUtilities::ComputeArea2DGeometry and ComputeVolume3DGeometry namely IntegrationUtilities::ComputeArea2DGeometryDerivative and IntegrationUtilities::ComputeVolume3DGeometryDerivative.

This PR is required for #11571 .

PS: I think the whole IntegrationUtilities class can be divided into .h and .cpp even though there are some inlined methods. @roigcarlo @matekelemen

馃啎 Changelog

  • Adds IntegrationUtilities::ComputeArea2DGeometryDerivative
  • Adds IntegrationUtilities::ComputeVolume3DGeometryDerivative
  • Adds tests

@sunethwarna sunethwarna requested a review from a team as a code owner September 25, 2023 14:58
@sunethwarna sunethwarna self-assigned this Sep 25, 2023
loumalouomega
loumalouomega reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

sunethwarna and others added 2 commits September 25, 2023 17:01
@sunethwarna @loumalouomega
Update kratos/tests/cpp_tests/utilities/test_integration_utilities.cpp
f856602 
Co-authored-by: Vicente Mataix Ferr谩ndiz <vmataix@altair.com>
@sunethwarna @loumalouomega
Update kratos/tests/cpp_tests/utilities/test_integration_utilities.cpp
3024061 
Co-authored-by: Vicente Mataix Ferr谩ndiz <vmataix@altair.com>
loumalouomega
loumalouomega previously approved these changes Sep 25, 2023
View reviewed changes
loumalouomega
loumalouomega approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@sunethwarna sunethwarna merged commit 811a999 into master Sep 26, 2023
10 of 11 checks passed
@sunethwarna sunethwarna deleted the core/integration_utilities/feature/derivatives branch September 26, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumalouomega loumalouomega loumalouomega approved these changes

@rubenzorrilla rubenzorrilla Awaiting requested review from rubenzorrilla

Assignees

@sunethwarna sunethwarna

Labels
C++ Feature Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunethwarna @loumalouomega