Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RomApp] BugFix RomManager on a multiparametric simulation #11612

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Rbravo555
Copy link
Member

馃摑 Description
This PR fixes a problem with the RomManager whenever a multiparametric simulation is launched. Once the parameters are passed to the first simulation, the object might be modified, and some simulations fail due to the presence of "new" fields in the parameters object, which make the validation process of the particular physics to fail.

馃啎 Changelog

  • Added a Parameters.Clone() to the different simulations in order not to add "new" fields

@Rbravo555 Rbravo555 requested a review from a team as a code owner September 26, 2023 18:12
@Rbravo555 Rbravo555 self-assigned this Sep 26, 2023
@Rbravo555 Rbravo555 added FastPR This Pr is simple and / or has been already tested and the revision should be fast ROM labels Sep 26, 2023
Copy link
Contributor

@SADPR SADPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fast PR.

@SADPR SADPR merged commit 3cd2d73 into master Sep 28, 2023
11 checks passed
@SADPR SADPR deleted the RomApp_BugfixRomManager branch September 28, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast ROM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants