Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Define and use PointLocalCoordinatesTetrahedra3D4N in Tetrahedra3D10 when planar face #11767

Merged
merged 4 commits into from
Nov 6, 2023
Merged

[Core] Define and use PointLocalCoordinatesTetrahedra3D4N in Tetrahedra3D10 when planar face #11767

merged 4 commits into from
Nov 6, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

Define and use PointLocalCoordinatesTetrahedra3D4N in Tetrahedra3D10 when planar face, for faster computation (explicit formula instead of iterative) and avoid non covergence.

🆕 Changelog

@loumalouomega loumalouomega requested a review from a team as a code owner November 3, 2023 22:53
ddiezrod
ddiezrod previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ddiezrod ddiezrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

rubenzorrilla
rubenzorrilla reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. The rest looks good to me.

@loumalouomega
Copy link
Member Author

Two minor comments. The rest looks good to me.

Done

rubenzorrilla
rubenzorrilla approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again.

@loumalouomega loumalouomega merged commit 02a5402 into master Nov 6, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/pointlocalcoordinates-tet10-face-planar branch November 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenzorrilla rubenzorrilla rubenzorrilla approved these changes

@ddiezrod ddiezrod ddiezrod left review comments

@jcotela jcotela Awaiting requested review from jcotela

@pooyan-dadvand pooyan-dadvand Awaiting requested review from pooyan-dadvand

@pablobecker pablobecker Awaiting requested review from pablobecker

Assignees

@loumalouomega loumalouomega

Labels
Enhancement Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loumalouomega @rubenzorrilla @ddiezrod