-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get files changed in PR #11825
Get files changed in PR #11825
Conversation
This reverts commit a88ff6f.
Were is the list printed? the CI only shows a variable :S |
@philbucher can you plz give a quick rundown on what this does? |
Sorry I marked too early as ready. I updated the description of the PR |
Out of curiosity, how are you planning to get the list of what needs to be run based on the modified files? I remember that I tried that once and I just gave up. I specially had problems with multilevel dependencies. for example: I modify process There is a script in the application In this case the CI would need to compile:
|
Also, consider that this: https://github.com/KratosMultiphysics/Kratos/tree/core/new-compile-pipeline will be merged soon™ |
I know, this will not conflict. In any case, I would adapt the developments to it if necessary |
Regarding the dependencies: I had similar thoughts. Given that a core change (which usually also happens daily) compiles everything, same as the nightly build I would say we are on the safe side. But I would discuss the details in the future |
This PR is the first step towards improving the CI by not always compiling everything. E.g. not always all apps need to be compiled, or not Cpp tests need to be compiled if only python files were changes. Stuff like this, ofc TBD once we actually want to introduce it
In a nutshell, this PR uses the github cli to get obtain the files modified in the PR. For now I am only printing them to observe it for a while. Eventually we can use them to refine the CI, see above