Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo/thermal tests documentation #11912

Merged
merged 15 commits into from
Jan 4, 2024
Merged

Conversation

indigocoral
Copy link
Contributor

📝 Description
Added README.md files for the thermal tests and made some changes to the tests

🆕 Changelog

  • README.md files are added for each type of thermal tests
  • Added test_transient_heat_flux_2D3N test as it was missing
  • The thermal tests are now categorized in folders based on their type of test
  • Boundary condition figures are changed according to team suggestion
  • Result animations are for the transient test cases with a fixed legend
  • Graph for results for steady state tests are added
  • "init" condition name is changed to "initial" for all tests

@indigocoral indigocoral linked an issue Dec 22, 2023 that may be closed by this pull request
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, the lingering MainKratos.py
Thank you for bringing more consistency and the nice documentation.



## Case Specification
In this thermal test case, a 1 x 1 m soil is considered, with the left side set at 0 degrees and the right side set at 25 degrees. The simulation spans 100 days to allow for a transition from an exponential to a linear temperature profile between the two sides. This test is conducted for various configurations, including 2D3N, 2D4N, 2D6N, 2D8N, 2D9N, 2D10N, 2D15N, 3D4N, and 3D10N. The temperature distribution within the box is then evaluated with its own result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial profile is not an exponential one, it is a step function ( starts from 0 everywhere, then a sudden jump to 25 at the right boundary ).



## Case Specification
In this thermal heat flux test case, a 1 x 1 m soil box is considered, with a 100 J/s.m2 heat flux applied as a condition to the bottom side and the top temperature set to 0 degrees. The simulation spans 100 days to allow for a transition from an exponential to a linear temperature profile between the two sides. This test is conducted for various configurations, including 2D3N, 2D4N, 2D6N, 2D8N, 2D9N, 2D10N, 2D15N, 3D4N, and 3D10N. The temperature distribution within the box is then evaluated with its own result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the J/s.m2 displays as intended. Both the time and length squared are below the division sign. the 2 is a power and hopefully a superscript.

WPK4FEM
WPK4FEM previously approved these changes Dec 22, 2023
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicer formatting!

Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marjan, a lot of work is done to have a good description. Just a few minor comments.

@indigocoral indigocoral self-assigned this Jan 4, 2024
Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marjan, congrats with the first work in the new year!

@indigocoral indigocoral merged commit bd8ecb9 into master Jan 4, 2024
16 of 17 checks passed
@indigocoral indigocoral deleted the geo/thermal-tests-documentation branch January 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Thermal tests documentation
3 participants