Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlet hydraulic process- Hydrograph as an inlet. #11915

Merged
merged 27 commits into from
Jan 16, 2024
Merged

Conversation

uxuech
Copy link
Contributor

@uxuech uxuech commented Dec 27, 2023

📝 Description

In this PR, the hydraulic inlet process is introduced.

This process allows the incorporation of a discharge through a function, table, or constant input. By specifying the input discharge, the corresponding depth is assigned based on the unit Froude number. Essentially, the fluid is introduced into the calculation domain under critical regime conditions.

To implement this, the process has been added, accompanied by its corresponding tests, and essential auxiliary utilities have been included to establish the critical depth.

🆕 Changelog

Process and test

  • apply_hydraulic_inlet_process.py
  • apply_hydraulic_inlet_process_test.py

Auxiliary utilties and test

  • hydraulic_fluid_auxiliary_utilities.cpp
  • hydraulic_fluid_auxiliary_utilities.h
  • test_hydraulic_fluid_auxiliary_utilities.py

Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff needs to be addressed before merging. Also note that tests have not been adding to their corresponding suites.

uxuech and others added 21 commits December 29, 2023 12:08
…es/hydraulic_fluid_auxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…es/hydraulic_fluid_auxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…/apply_hydraulic_inlet_process.py

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…/apply_hydraulic_inlet_process_test.py

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…/apply_hydraulic_inlet_process.py

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…/apply_hydraulic_inlet_process_test.py

Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
@uxuech uxuech requested a review from a team as a code owner January 12, 2024 10:07
@uxuech uxuech merged commit 0fad41b into master Jan 16, 2024
16 of 17 checks passed
@uxuech uxuech deleted the hydraulic_inlet_process branch January 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants