Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrilinosApplication] Some minor improvements in MPC B&S #11918

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

In this PR, changes have been made to the TrilinosBlockBuilderAndSolver class in the file trilinos_block_builder_and_solver.h. The main purpose of the commit is to optimize the synchronization of inactive slave degree of freedom (DOF) information between partitions.

  1. It begins by initializing a variable num_inactive_slave_dofs_other_partitions to 0.
  2. It then iterates over master-slave constraints, updating mInactiveSlaveDofs and num_inactive_slave_dofs_other_partitions accordingly.
  3. After this, it calculates the total number of inactive slave DOFs in other partitions using communication via r_data_comm.
  4. If there are inactive slave DOFs in other partitions (num_inactive_slave_dofs_other_partitions > 0), it proceeds to synchronize this information between partitions using communication via r_data_comm. The synchronization process involves sending and receiving inactive slave DOF IDs between different ranks.

🆕 Changelog

@loumalouomega loumalouomega added Enhancement Applications External library Parallel-MPI Distributed memory parallelism for HPC / clusters FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Dec 28, 2023
@loumalouomega loumalouomega requested review from a team as code owners December 28, 2023 15:02
Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test would be good

@loumalouomega loumalouomega merged commit 656ee4c into master Dec 28, 2023
17 checks passed
@loumalouomega loumalouomega deleted the trilinos/some-improvements-b&s-mpc branch December 28, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Enhancement External library FastPR This Pr is simple and / or has been already tested and the revision should be fast Parallel-MPI Distributed memory parallelism for HPC / clusters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants