Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Split ApplyK0ProcedureProcess into a header and source file #11939

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Jan 11, 2024

📝 Description
Minor PR to split the ApplyK0Procedure class .hpp file in a .h and .cpp file.

@rfaasse rfaasse requested a review from avdg81 January 11, 2024 12:31
@rfaasse rfaasse self-assigned this Jan 11, 2024
@rfaasse rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Jan 11, 2024
@rfaasse rfaasse changed the title [GeoMechanicsApplication] [GeoMechanicsApplication] Split ApplyK0ProcedureProcess into a header and source file Jan 11, 2024
@rfaasse rfaasse enabled auto-merge (squash) January 11, 2024 12:34
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the original .hpp file in a header file and an implementation file. This makes the code easier to read, since the class's interface has been nicely separated from the implementation details. Well done Richard!

@rfaasse rfaasse merged commit c56cf92 into master Jan 11, 2024
17 checks passed
@rfaasse rfaasse deleted the geo/split-k0-process branch January 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants