-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OptApp] NAG method #12006
[OptApp] NAG method #12006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have minor comments. Otherwise, this is cool :)
...OptimizationApplication/python_scripts/algorithms/algorithm_nesterov_accelarated_gradient.py
Outdated
Show resolved
Hide resolved
if isinstance(alpha, float): | ||
update = search_direction * alpha | ||
elif isinstance(alpha, KratosOA.CollectiveExpression): | ||
update = search_direction.Scale(alpha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if isinstance(alpha, float): | |
update = search_direction * alpha | |
elif isinstance(alpha, KratosOA.CollectiveExpression): | |
update = search_direction.Scale(alpha) | |
update = Kratos.Expression.Utils.Scale(search_direction, alpha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Igarizza.
@sunethwarna Why can DEMApplication fail? |
No idea... But we are not touching it, so it should be safe. |
📝 Description
Adding new optimization method for unconstrained problems.