-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Correcting corner case in GeometricalObjectBins
+ typo ("avarage")
#12016
[Core] Correcting corner case in GeometricalObjectBins
+ typo ("avarage")
#12016
Conversation
for (unsigned int i = 0; i < Dimension; i++) { | ||
mNumberOfCells[i] = 0; | ||
mCellSizes[i] = 0.0; | ||
mInverseOfCellSize[i] = std::numeric_limits<double>::max(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pooyan-dadvand change is this
mNumberOfCells[i] = 0; | ||
mCellSizes[i] = 0.0; | ||
mInverseOfCellSize[i] = std::numeric_limits<double>::max(); | ||
} | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to thgis return values were not initialized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding it!
📝 Description
Correcting corner case in
GeometricalObjectBins
, where due to the return clause,mNumberOfCells
,mCellSizes
andmInverseOfCellSize
were not initialized.🆕 Changelog
GeometricalObjectBins